Antique Coins
Don't clean antique coins of any value. If you don't know if they're valuable, still don't clean them. Antique coin collectors are looking for coins in their closest original condition. Rather, store them in coin holders and don't touch them, except by the edges when necessary. If you really want them cleaned, take valuable coins to a professional coin cleaner.
If you are sure your coins are not valuable and want to clean them yourself, avoid harsh chemicals and abrasive cleaners such as metal polishing cloth, vinegar and baking soda. Also, don't use metal brushes, rock tumblers or other tools that could damage the coins. Rather, clean with warm soapy water. The water should be distilled, not tap. Simply add 1 tsp. of dish detergent per pint of water and let the coins soak for several hours. Afterward, use a soft cotton rag to gently rub the coin clean. Some people prefer a soft toothbrush, but you have to be very gentle since you may easily scratch the metal's surface, especially gold. You can also put petroleum jelly on each side of the coin and gently rub it in with a cotton swab. This will help get rid of any residue build up. Again, if a coin is valuable or you are unsure of its value, don't clean it yourself.
New Coins
Newer coins that are not collectibles and are not worth money other than their face value can be cleaned with a couple of recipes. In general, to clean all your coins, you can us 2 tbsp. of salt mixed with 1 cup of vinegar. Let your coins soak until they look new and shiny, but only do one metal at a time. If necessary, gently scrub them with a soft toothbrush. Rinse with distilled water and let them air dry. Ketchup, which has both tomatoes and vinegar in it, can be used to clean pennies. Lemon juice also works well to clean pennies, as well as silver coins.